[Toolkit][Shadcn] Add Dialog component
#3173
Conversation
carsonbot
added
Documentation
|
Hey, and thanks for the contribution! That's super appreciated 🤗 I don't see any issue with the closing icon, it's well displayed: About the "focus trap" thing, I agree. I didn't see native things and the solution used in by Shadcn/RadixUI seems very complex. Thanks! |
src/Toolkit/kits/shadcn/dialog/templates/components/Dialog/Content.html.twig
Show resolved
Hide resolved
| @@ -0,0 +1,15 @@ | |||
| {# @prop open boolean Open (or not) the Dialog at initial rendering, default to `false` #} | |||
seb-jean
force-pushed
the
toolkit-shadcn-dialog
branch
from
42dd883 to
a4a31fe
Compare
I'll look into improving the focus section. |
|
I think you should remove the |
4 participants
This pull request introduces the new
Dialogcomponent to the Shadcn UI kit in the Symfony UX Toolkit, including its templates for all subcomponents (Close, Content, Description, Footer, Header, Title, Trigger), JavaScript controller, documentation, and manifest.I encountered a display issue with the
Labelcomponent. So I updated this component to reflect Shadcn.Below is a demonstration of the
Dialogcomponent:Dialog.mp4
However, I am having a problem with the
lucid-xicon. In the middle of it, there is what looks like a white line.The second problem I see is that when using the Tab key while the dialog is open, elements outside the dialog can also be focused. This is unacceptable.
What do you think?
(In any case, this kit system is great, and it's only the beginning.)